[ 
https://issues.apache.org/jira/browse/HDFS-16979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712004#comment-17712004
 ] 

ASF GitHub Bot commented on HDFS-16979:
---------------------------------------

virajjasani commented on PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#issuecomment-1507395844

   IMHO we could do something like this: add a new key/value pair in the 
CallerContext at RouterRpcClient level, e.g. `append("isRouter", "true")` and 
then at audit log level, instead of only relying on `isClientPortInfoAbsent()`, 
we can also check if the context has `isRouter` key present with value `true`. 
If so, then add `dfsrouterPort` with remote port (same logic as `else` part in 
this PR).
   Thoughts?




> RBF: Add dfsrouter port in hdfsauditlog
> ---------------------------------------
>
>                 Key: HDFS-16979
>                 URL: https://issues.apache.org/jira/browse/HDFS-16979
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: liuguanghua
>            Priority: Major
>              Labels: pull-request-available
>
> When remote client request through dfsrouter to namenode, the hdfsauditlog 
> record the remote client ip and port ,dfsrouter IP,but lack of dfsrouter port.
> This patch is done for this scene.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to