[
https://issues.apache.org/jira/browse/HDFS-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713210#comment-17713210
]
ASF GitHub Bot commented on HDFS-16982:
---------------------------------------
goiri commented on code in PR #5556:
URL: https://github.com/apache/hadoop/pull/5556#discussion_r1169028613
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java:
##########
@@ -52,6 +52,8 @@ public class TestMutableMetrics {
private static final Logger LOG =
LoggerFactory.getLogger(TestMutableMetrics.class);
private static final double EPSILON = 1e-42;
+ private static final int SLEEP_TIME = 6000;
Review Comment:
SLEEP_TIME_MS = 6 * 1000; // 6 seconds
> Use the right Quantiles Array for Inverse Quantiles snapshot
> -------------------------------------------------------------
>
> Key: HDFS-16982
> URL: https://issues.apache.org/jira/browse/HDFS-16982
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, metrics
> Reporter: Ravindra Dingankar
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.3.0, 3.4.0
>
>
> HDFS-16949 introduced InverseQuantiles. However during snapshot for Inverse
> Quantiles we were still trying to access values from previous snapshot based
> on the Quantile Array declared in MutableQuantiles. ( Quantile(.50, .050),
> Quantile(.75, .025), Quantile(.90, .010), Quantile(.95, .005), Quantile(.99,
> .001) )
> For InverseQuantiles we wont have these values ( except for Quantile(.50,
> .050) ) thus except for 50 Percentile snapshot wont return any value for the
> remaining quantiles.
> Fix is to use the correct Quantiles Array to retrieve values during snapshot.
> The new UTs verify this behavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
