[
https://issues.apache.org/jira/browse/HDFS-16983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caozhiqiang updated HDFS-16983:
-------------------------------
Description:
In concat RPC, it will call FSDirConcatOp::verifySrcFiles() to check the source
files. In this function, it would make permission check for srcs. Whether do
the permission check should be decided by dfs.permissions.enabled
configuration. And the 'pc' parameter is always not null.
So we should change 'if (pc != null)' to 'if (fsd.isPermissionEnabled())'.
{code:java}
// permission check for srcs
if (pc != null) {
fsd.checkPathAccess(pc, iip, FsAction.READ); // read the file
fsd.checkParentAccess(pc, iip, FsAction.WRITE); // for delete
}
{code}
was:
In concat RPC, it will call FSDirConcatOp::verifySrcFiles() to check the source
files. In this function, it would make permission check for srcs. Whether do
the permission check should be decided by dfs.permissions.enabled
configuration. And the 'pc' parameter is always not null.
{code:java}
// permission check for srcs
if (pc != null) {
fsd.checkPathAccess(pc, iip, FsAction.READ); // read the file
fsd.checkParentAccess(pc, iip, FsAction.WRITE); // for delete
} {code}
> Whether checking path access permissions should be decided by
> dfs.permissions.enabled in concat operation
> ---------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16983
> URL: https://issues.apache.org/jira/browse/HDFS-16983
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.4.0
> Reporter: caozhiqiang
> Assignee: caozhiqiang
> Priority: Major
> Labels: pull-request-available
>
> In concat RPC, it will call FSDirConcatOp::verifySrcFiles() to check the
> source files. In this function, it would make permission check for srcs.
> Whether do the permission check should be decided by dfs.permissions.enabled
> configuration. And the 'pc' parameter is always not null.
> So we should change 'if (pc != null)' to 'if (fsd.isPermissionEnabled())'.
> {code:java}
> // permission check for srcs
> if (pc != null) {
> fsd.checkPathAccess(pc, iip, FsAction.READ); // read the file
> fsd.checkParentAccess(pc, iip, FsAction.WRITE); // for delete
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
