[
https://issues.apache.org/jira/browse/HDFS-16978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715105#comment-17715105
]
ASF GitHub Bot commented on HDFS-16978:
---------------------------------------
simbadzina commented on code in PR #5554:
URL: https://github.com/apache/hadoop/pull/5554#discussion_r1173987391
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableManager.java:
##########
@@ -48,6 +50,17 @@ public interface MountTableManager {
AddMountTableEntryResponse addMountTableEntry(
AddMountTableEntryRequest request) throws IOException;
+ /**
+ * All multiple entries to the mount table.
Review Comment:
Typo "Add" vs "All"
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java:
##########
@@ -132,15 +135,15 @@ public void printUsage() {
System.out.println(usage);
}
- private void printUsage(String cmd) {
+ private static void printUsage(String cmd) {
String usage = getUsage(cmd);
System.out.println(usage);
}
- private String getUsage(String cmd) {
+ private static String getUsage(String cmd) {
if (cmd == null) {
String[] commands =
- {"-add", "-update", "-rm", "-ls", "-getDestination", "-setQuota",
+ {"-add", "-addall", "-update", "-rm", "-ls", "-getDestination",
"-setQuota",
Review Comment:
Can you use camelCase like the other two word commands.
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterAdminServer.java:
##########
@@ -358,6 +360,25 @@ public AddMountTableEntryResponse addMountTableEntry(
return getMountTableStore().addMountTableEntry(request);
}
+ @Override
+ public AddMountTableEntriesResponse
addMountTableEntries(AddMountTableEntriesRequest request)
+ throws IOException {
+ List<MountTable> mountTables = request.getEntries();
+ for (MountTable mountTable : mountTables) {
+ verifyMaxComponentLength(mountTable);
+ }
+ if (this.mountTableCheckDestination) {
+ for (MountTable mountTable : mountTables) {
+ List<String> nsIds = verifyFileInDestinations(mountTable);
+ if (!nsIds.isEmpty()) {
+ throw new IllegalArgumentException(
+ "File not found in downstream " + "nameservices: " +
StringUtils.join(",", nsIds));
+ }
Review Comment:
This code is now duplicated in three places. Can we move it into a small
separate function.
> RBF: Admin command to support bulk add of mount points
> ------------------------------------------------------
>
> Key: HDFS-16978
> URL: https://issues.apache.org/jira/browse/HDFS-16978
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
> Labels: pull-request-available
>
> All state store implementations support adding multiple state store records
> using single putAll() implementation. We should provide new router admin API
> to support bulk addition of mount table entries that can utilize this build
> add implementation at state store level.
> For more than one mount point to be added, the goal of bulk addition should be
> # To reduce frequent router calls
> # To avoid frequent state store cache refreshers with each single mount
> point addition
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
