[ 
https://issues.apache.org/jira/browse/HDFS-16994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717019#comment-17717019
 ] 

ASF GitHub Bot commented on HDFS-16994:
---------------------------------------

hfutatzhanghb opened a new pull request, #5600:
URL: https://github.com/apache/hadoop/pull/5600

   ### Description of PR
   For now, the NumTimedOutPendingReconstructions metric is computed by below 
statement:
   ```java
   timedOutCount + timedOutItems.size(); 
   ```
   
   Therefore, its value would always be accumulated unless namenode failover 
happens. 
   
   In fact, the NumTimedOutPendingReconstructions metric should not be 
accumulated, So, we should set it to zero after we execute getNumTimedOuts 
method.
   
   
   ### How was this patch tested?
   The UT TestPendingReconstruction#testPendingReconstruction was passed.
   




> NumTimedOutPendingReconstructions metrics should not be accumulated
> -------------------------------------------------------------------
>
>                 Key: HDFS-16994
>                 URL: https://issues.apache.org/jira/browse/HDFS-16994
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: farmmamba
>            Priority: Minor
>
> For now, the NumTimedOutPendingReconstructions metric is computed by below 
> statement:
> {code:java}
> timedOutCount + timedOutItems.size(); {code}
> Therefore, its value would always be accumulated unless namenode failover 
> happens. 
> In fact, the NumTimedOutPendingReconstructions metric should not be 
> accumulated, So, we should set it to zero after we execute getNumTimedOuts 
> method.
> The UT TestPendingReconstruction#testPendingReconstruction was passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to