[ 
https://issues.apache.org/jira/browse/HDFS-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717132#comment-17717132
 ] 

ASF GitHub Bot commented on HDFS-16995:
---------------------------------------

wzhallright commented on code in PR #5601:
URL: https://github.com/apache/hadoop/pull/5601#discussion_r1179008621


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java:
##########
@@ -159,9 +158,8 @@ void start() throws IOException {
       httpServer.setAttribute(DFSConfigKeys.DFS_DATANODE_HTTPS_PORT_KEY,
           datanodeSslPort.getPort());
     }
-    String httpKeytab = conf.get(DFSUtil.getSpnegoKeytabKey(conf,
-        DFSConfigKeys.DFS_NAMENODE_KEYTAB_FILE_KEY));
-    initWebHdfs(conf, bindAddress.getHostName(), httpKeytab, httpServer,
+
+    initWebHdfs(conf, httpServer,
         NamenodeWebHdfsMethods.class.getPackage().getName());

Review Comment:
   @ayushtkn I've formatted the code, please take a review when you have 
time.Thanks.





> Remove unused parameters at NameNodeHttpServer#initWebHdfs
> ----------------------------------------------------------
>
>                 Key: HDFS-16995
>                 URL: https://issues.apache.org/jira/browse/HDFS-16995
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Zhaohui Wang
>            Assignee: Zhaohui Wang
>            Priority: Minor
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to