[
https://issues.apache.org/jira/browse/HDFS-16979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719255#comment-17719255
]
ASF GitHub Bot commented on HDFS-16979:
---------------------------------------
ayushtkn commented on code in PR #5552:
URL: https://github.com/apache/hadoop/pull/5552#discussion_r1184829824
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java:
##########
@@ -50,7 +50,8 @@ public final class CallerContext {
public static final String CLIENT_ID_STR = "clientId";
public static final String CLIENT_CALL_ID_STR = "clientCallId";
public static final String REAL_USER_STR = "realUser";
-
+ public static final String IS_DFSROUTER = "isDfsRouter";
+ public static final String DFSROUTER_PORT_STR = "dfsRouterPort";
Review Comment:
There is no point having dfsRouterPort or is isDfsRouter, the code is very
generic and adding Router specific code should be the last thing to do in the
Namenode, Namenode doesn't care whether router is proxying or any xyz client
or service is proxying.
Change it to be generic Proxy Client port nothing exactly router specific in
the Namenode
> RBF: Add dfsrouter port in hdfsauditlog
> ---------------------------------------
>
> Key: HDFS-16979
> URL: https://issues.apache.org/jira/browse/HDFS-16979
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: liuguanghua
> Priority: Major
> Labels: pull-request-available
>
> When remote client request through dfsrouter to namenode, the hdfsauditlog
> record the remote client ip and port ，dfsrouter IP，but lack of dfsrouter port.
> This patch is done for this scene.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
