[ 
https://issues.apache.org/jira/browse/HDFS-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721133#comment-17721133
 ] 

ASF GitHub Bot commented on HDFS-16965:
---------------------------------------

tomscut commented on code in PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#discussion_r1189267598


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/CodecUtil.java:
##########
@@ -170,8 +174,14 @@ private static String[] getRawCoderNames(
 
   private static RawErasureEncoder createRawEncoderWithFallback(
       Configuration conf, String codecName, ErasureCoderOptions coderOptions) {
+    boolean ISALEnabled = 
conf.getBoolean(IO_ERASURECODE_CODEC_NATIVE_ENABLED_KEY,

Review Comment:
   Please change the case of this variable.





> Add switch to decide whether to enable native codec.
> ----------------------------------------------------
>
>                 Key: HDFS-16965
>                 URL: https://issues.apache.org/jira/browse/HDFS-16965
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: erasure-coding
>    Affects Versions: 3.3.4
>            Reporter: WangYuanben
>            Priority: Minor
>              Labels: pull-request-available
>
> Sometimes we need to create codec without ISA-L, while priority is given to 
> native codec by default. So it is necessary to add switch to decide whether 
> to enable native codec.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to