[ 
https://issues.apache.org/jira/browse/HDFS-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721949#comment-17721949
 ] 

ASF GitHub Bot commented on HDFS-17008:
---------------------------------------

goiri commented on code in PR #5648:
URL: https://github.com/apache/hadoop/pull/5648#discussion_r1191783244


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -484,14 +486,14 @@ private RetryDecision shouldRetry(final IOException ioe, 
final int retryCount,
    * Invokes a method against the ClientProtocol proxy server. If a standby
    * exception is generated by the call to the client, retries using the
    * alternate server.
-   *

Review Comment:
   Does this give warnings? If no, it is easier to read with the break line.
   The other option is to explicitly add the breakline.





> Fix RBF JDK 11 javadoc warnings
> -------------------------------
>
>                 Key: HDFS-17008
>                 URL: https://issues.apache.org/jira/browse/HDFS-17008
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>
> HDFS-16978 excluded proto packages from maven-javadoc-plugin for rbf, hence 
> now we have JDK 11 javadoc warnings (e.g. 
> [here|https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5554/14/artifact/out/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-rbf-jdkUbuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1.txt]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to