[ 
https://issues.apache.org/jira/browse/HDFS-17007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721996#comment-17721996
 ] 

ASF GitHub Bot commented on HDFS-17007:
---------------------------------------

LiuGuH commented on PR #5642:
URL: https://github.com/apache/hadoop/pull/5642#issuecomment-1545057769

         GenericTestUtils.waitFor(() -> pendingReconstruction.size() == 0, 500,
             10000);
         // The pending queue should be empty.
         assertEquals("Size of pendingReconstructions ", 0,
             pendingReconstruction.size());
       } finally {
         if (cluster != null) {
           cluster.shutdown();
         }
       }
   
   GenericTestUtils.waitFor() will  sleep maximum 10s.  The 
pendingReconstruction  will timeout after 3s ,then will be into timeout list. 
   PendingReconstructionMonitor will not be stoped if I change  
GenericTestUtils.waitFor to 1s .
   




> TestPendingReconstruction.testProcessPendingReconstructions verify HDFS-11960 
> test case is wrong
> ------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17007
>                 URL: https://issues.apache.org/jira/browse/HDFS-17007
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: liuguanghua
>            Priority: Minor
>
> TestPendingReconstruction.testProcessPendingReconstructions() verify 
> HDFS-11960 is wrong.
> (1) It does not  stop PendingReconstructionMonitor. The blockid will into 
> timeouts queue because of timout duration is 3s.
> (2) Test blockid should be blk_1_1 with different genstamp.  
> (3) The blk_1_1 should test with the same DatanodeDescriptor



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to