[ 
https://issues.apache.org/jira/browse/HDFS-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724137#comment-17724137
 ] 

Viraj Jasani commented on HDFS-17017:
-------------------------------------

{quote}btw. lets fix something when it is broken, or give suggestions on how 
the fix could be better rather than telling ok, this is a minor thing, it won't 
happen, or it was the tests fault old people didn't cover, anybody can miss 
anything in the code, lets not make the one who found a valid bug even small 
feel any less when it is very valid use case, not dragging it further, saw this 
as a repetitive occurrence, just a friendly 2 cents rest upto you
{quote}
Ayush, I am not sure why you would think that I am making anyone feel bad for 
this, I really appreciate this fix and I have suggested test change to make the 
fix even better with solid test. It has never been my intention to say that old 
ppl didn't cover something, I would never say that. Hadoop is massive codebase, 
things can be missed. For this fix, i agree that it was a miss from HDFS-16521. 
I am not denying it.

I hope I have not offended you and if you felt that way, I apologize, that was 
never my purpose, i was just providing my viewpoint that while testing the 
changes, i only used it with "-live" because my usecase was "live but not slow" 
but you are right that usecase could be different too.

> Fix the issue of arguments number limit in report command in DFSAdmin.
> ----------------------------------------------------------------------
>
>                 Key: HDFS-17017
>                 URL: https://issues.apache.org/jira/browse/HDFS-17017
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haiyang Hu
>            Assignee: Haiyang Hu
>            Priority: Major
>
> Currently, the DFSAdmin report command should support a maximum number of 
> arguments of 7, such as :
> hdfs dfsadmin [-report] [-live] [-dead] [-decommissioning] 
> [-enteringmaintenance] [-inmaintenance] [-slownodes]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to