[
https://issues.apache.org/jira/browse/HDFS-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724476#comment-17724476
]
ASF GitHub Bot commented on HDFS-17014:
---------------------------------------
zhtttylz commented on code in PR #5660:
URL: https://github.com/apache/hadoop/pull/5660#discussion_r1199540321
##########
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java:
##########
@@ -2081,6 +2085,32 @@ private void testGetFileLinkStatus() throws Exception {
assertTrue(fs.getFileLinkStatus(linkToFile).isSymlink());
}
+ private void testGetStatus() throws Exception {
+ if (isLocalFS()) {
+ // do not test the getStatus for local FS.
+ return;
+ }
+ final Path path = new Path("/foo");
+ FileSystem fs = FileSystem.get(path.toUri(), this.getProxiedFSConf());
+ if (fs instanceof DistributedFileSystem) {
+ DistributedFileSystem dfs =
+ (DistributedFileSystem) FileSystem.get(path.toUri(),
this.getProxiedFSConf());
+ FileSystem httpFs = this.getHttpFSFileSystem();
+
+ FsStatus dfsFsStatus = dfs.getStatus(path);
+ FsStatus httpFsStatus = httpFs.getStatus(path);
+
+ //Validate used free and capacity are the same as DistributedFileSystem
+ assertEquals(dfsFsStatus.getUsed(), httpFsStatus.getUsed());
+ assertEquals(dfsFsStatus.getRemaining(), httpFsStatus.getRemaining());
+ assertEquals(dfsFsStatus.getCapacity(), httpFsStatus.getCapacity());
+ httpFs.close();
+ dfs.close();
+ }else{
+ Assert.fail(fs.getClass().getSimpleName() + " is not of type
DistributedFileSystem.");
+ }
Review Comment:
Thank you very much for your valuable suggestion. I genuinely appreciate it
and will make the necessary adjustments to the code promptly.
> HttpFS Add Support getStatus API
> --------------------------------
>
> Key: HDFS-17014
> URL: https://issues.apache.org/jira/browse/HDFS-17014
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: webhdfs
> Affects Versions: 3.4.0
> Reporter: Hualong Zhang
> Assignee: Hualong Zhang
> Priority: Major
> Labels: pull-request-available
>
> We should ensure that *WebHDFS* remains synchronized with {*}HttpFS{*}, as
> the former has already implemented the *getStatus* interface.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
