[ 
https://issues.apache.org/jira/browse/HDFS-17000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724971#comment-17724971
 ] 

Ayush Saxena commented on HDFS-17000:
-------------------------------------

Hi [~Marcono1234] 

Yep, changing to Integer.MAX_VALUE makes sense.
{quote}If you want I can create a pull request, unless it is easier for you to 
directly do this yourself. However, I won't sign the Apache Contributor License 
agreement for this small change.
{quote}
I would suggest you should raise a PR, It is your find, you have the solution, 
why you want to give it to me or anybody else :) , I will be happy to review & 
merge.
{quote}I won't sign the Apache Contributor License agreement for this small 
change.
{quote}
That is not required either. That is optional activity. You just need to raise 
a Pull Request to trunk with the change.

> Potential infinite loop in 
> TestDFSStripedOutputStreamUpdatePipeline.testDFSStripedOutputStreamUpdatePipeline
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-17000
>                 URL: https://issues.apache.org/jira/browse/HDFS-17000
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Marcono1234
>            Priority: Major
>
> The method 
> {{TestDFSStripedOutputStreamUpdatePipeline.testDFSStripedOutputStreamUpdatePipeline}}
>  contains the following line:
> {code}
> for (int i = 0; i < Long.MAX_VALUE; i++) {
> {code}
> [GitHub source 
> link|https://github.com/apache/hadoop/blob/4ee92efb73a90ae7f909e96de242d216ad6878b2/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamUpdatePipeline.java#L48]
> Because {{i}} is an {{int}} the condition {{i < Long.MAX_VALUE}} will always 
> be true and {{i}} will simply overflow.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to