[ https://issues.apache.org/jira/browse/HDFS-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726826#comment-17726826 ]
ASF GitHub Bot commented on HDFS-17026: --------------------------------------- simbadzina commented on code in PR #5691: URL: https://github.com/apache/hadoop/pull/5691#discussion_r1208076743 ########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NamenodeHeartbeatService.java: ########## @@ -447,8 +462,13 @@ private void updateJMXParameters( String address, NamenodeStatusReport report) { try { // TODO part of this should be moved to its own utility - getFsNamesystemMetrics(address, report); - getNamenodeInfoMetrics(address, report); + if (shouldUpdateJmx()) { + lastJmxUpdateAttempt = Time.monotonicNow(); + getFsNamesystemMetrics(address); + getNamenodeInfoMetrics(address); + } + populateFsNamesystemMetrics(fsNamesystemMetrics, report); + populateNamenodeInfoMetrics(namenodeInfoMetrics, report); Review Comment: I see, so we want the last value to be seen instead of a zero. > RBF: NamenodeHeartbeatService should update JMX report with configurable > frequency > ---------------------------------------------------------------------------------- > > Key: HDFS-17026 > URL: https://issues.apache.org/jira/browse/HDFS-17026 > Project: Hadoop HDFS > Issue Type: Improvement > Components: rbf > Reporter: Hector Sandoval Chaverri > Priority: Major > Labels: pull-request-available > > TheĀ NamenodeHeartbeatService currently calls each of the Namenode's JMX > endpoint every time it wakes up (default value is every 5 seconds). > In a cluster with 40 routers, we have observed service degradation on some of > theĀ Namenodes, since the JMX request obtains Datanode status and blocks > other RPC requests. However, JMX report data doesn't seem to be used for > critical paths on the routers. > We should configure the NamenodeHeartbeatService so it updates the JMX > reports on a slower frequency than the Namenode states or to disable the > reports completely. > The class calls out the JMX request being optional even though there is no > implementation to turn it off: > {noformat} > // Read the stats from JMX (optional) > updateJMXParameters(webAddress, report);{noformat} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org