[
https://issues.apache.org/jira/browse/HDFS-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727163#comment-17727163
]
ASF GitHub Bot commented on HDFS-17027:
---------------------------------------
goiri commented on code in PR #5693:
URL: https://github.com/apache/hadoop/pull/5693#discussion_r1209483769
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java:
##########
@@ -51,13 +51,16 @@
import
org.apache.hadoop.hdfs.server.federation.resolver.FederationNamenodeServiceState;
import
org.apache.hadoop.hdfs.server.federation.resolver.MembershipNamenodeResolver;
import org.apache.hadoop.hdfs.server.namenode.NameNode;
+import
org.apache.hadoop.hdfs.server.namenode.ha.RouterObserverReadProxyProvider;
Review Comment:
This test is not specifically checking anything on msyncs. Can we add
something?
> RBF: Add supports for observer.auto-msync-period when using routers
> -------------------------------------------------------------------
>
> Key: HDFS-17027
> URL: https://issues.apache.org/jira/browse/HDFS-17027
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Simbarashe Dzinamarira
> Assignee: Simbarashe Dzinamarira
> Priority: Major
> Labels: pull-request-available
>
> None-RBF clients that use observer reads have the option to set
> *dfs.client.failover.observer.auto-msync-period.<nameservice>* . This config
> makes the client automatically do an msync, allowing clients to use the
> observer reads feature without any code change.
> To use observer reads with RBF, clients set
> *dfs.client.rbf.observer.read.enable*. The way this flag is implemented does
> not allow clients to use the *auto-msync-period* config. So with RBF, clients
> either have to
> # Not use observer reads
> # Use observer reads with the risk of stale reads
> # Make code changes to explicitly call msync.
> We should add support for
> *dfs.client.failover.observer.auto-msync-period.<nameservice>*. This can be
> done by adding a ProxyProvider, in a similar manner to the
> ObserverReadProxyProvider.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
