[
https://issues.apache.org/jira/browse/HDFS-17060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736978#comment-17736978
]
ASF GitHub Bot commented on HDFS-17060:
---------------------------------------
hfutatzhanghb commented on code in PR #5778:
URL: https://github.com/apache/hadoop/pull/5778#discussion_r1241488678
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java:
##########
@@ -1236,11 +1245,17 @@ public DatanodeStorageInfo chooseReplicaToDelete(
minSpace = free;
minSpaceStorage = storage;
}
+ if (considerLoad2chooseReplicaDeleting && nodeLoad < minLoad) {
+ minLoad = nodeLoad;
+ minLoadStorage = storage;
+ }
}
final DatanodeStorageInfo storage;
if (oldestHeartbeatStorage != null) {
storage = oldestHeartbeatStorage;
+ } else if (minLoadStorage != null) {
Review Comment:
@Hexiaoqiao Sir, thanks for your reply. If we open the configuration
mentioned in this PR, we should consider load first and we keep running
Balancer background. And I also have thinked some improvements about the
changes:
1. should we consider load use `load.factor` like
`dfs.namenode.redundancy.considerLoad.factor`?
2. should we add another configuration to judge the difference between two
storage's remaining in an acceptable range?
Looking forward to your reply~ Thanks sir.
> BlockPlacementPolicyDefault#chooseReplicaToDelete should consider datanode
> load
> -------------------------------------------------------------------------------
>
> Key: HDFS-17060
> URL: https://issues.apache.org/jira/browse/HDFS-17060
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
> When choose extra replicas for deleting, we should consider datanode load as
> well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
