[ 
https://issues.apache.org/jira/browse/HDFS-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198983#comment-13198983
 ] 

Todd Lipcon commented on HDFS-2877:
-----------------------------------

Uma's got it -- the RandomAccessFile constructor will create the file, but 
then, if we fail to lock that file we just created, we wouldn't clean it up. 
(eg if the underlying system is an NFS mount without NLM)
                
> If locking of a storage dir fails, it will remove the other NN's lock file on 
> exit
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-2877
>                 URL: https://issues.apache.org/jira/browse/HDFS-2877
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0, 0.24.0, 1.0.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2877.txt
>
>
> In {{Storage.tryLock()}}, we call {{lockF.deleteOnExit()}} regardless of 
> whether we successfully lock the directory. So, if another NN has the 
> directory locked, then we'll fail to lock it the first time we start another 
> NN. But our failed start attempt will still remove the other NN's lockfile, 
> and a second attempt will erroneously start.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to