[ https://issues.apache.org/jira/browse/HDFS-17121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747504#comment-17747504 ]
ASF GitHub Bot commented on HDFS-17121: --------------------------------------- Hexiaoqiao commented on PR #5888: URL: https://github.com/apache/hadoop/pull/5888#issuecomment-1651784829 > And maybe it not a problem. I am sure IT IS (As @tomscut mentioned above.). IMO, if there is issue that confirmed, the proper way is fix it first then improve it. I believe this proposal is very important, actually we have deploy this feature for years, however we should be safe to land it. I think the simple way is adding mutex/lock to avoid IBR and FBR mis-order. Maybe there is some other smooth way, welcome to discussion. Good luck! > BPServiceActor to provide new thread to handle FBR > -------------------------------------------------- > > Key: HDFS-17121 > URL: https://issues.apache.org/jira/browse/HDFS-17121 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Reporter: liuguanghua > Priority: Minor > Labels: pull-request-available > > After HDFS-16016 , it makes ibr in a thread to avoid heartbeat blocking with > ibr when require readlock in Datanode. > Now fbr should do as this. The reason is this: > (1)heartbeat maybe block because of fbr with readlock in datanode > (2)fbr will only may return FinalizeCommand -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org