[ 
https://issues.apache.org/jira/browse/HDFS-17134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748598#comment-17748598
 ] 

ASF GitHub Bot commented on HDFS-17134:
---------------------------------------

zhangshuyan0 opened a new pull request, #5900:
URL: https://github.com/apache/hadoop/pull/5900

   ### Description of PR
   
   The result of `getListing` in NameNode are sorted based on `byte[]`, while 
the Router side is based on `String`. If there are special characters in path, 
the sorting result of the router will be inconsistent with the namenode. This 
may result in duplicate `getListing` results obtained by the client due to 
wrong `startAfter` parameter.
   For exemple, namenode returns [path1, path2, path3] for a `getListing` 
request, while router returns [path1, path3, path2] to client. Then client will 
pass `path2` as `startAfter`  at the next iteration, so it will receive `path3` 
again.
   We need to fix the Router code so that the order of its result is the same 
as NameNode.
   
   ### How was this patch tested?
   Add a new unit test.
   
   




> RBF: Fix duplicate results of getListing through Router.
> --------------------------------------------------------
>
>                 Key: HDFS-17134
>                 URL: https://issues.apache.org/jira/browse/HDFS-17134
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Shuyan Zhang
>            Assignee: Shuyan Zhang
>            Priority: Major
>
> The result of `getListing` in NameNode are sorted based on `byte[]`, while 
> the Router side is based on `String`. If there are special characters in 
> path, the sorting result of the router is inconsistent with the namenode. 
> This may result in duplicate `getListing` results obtained by the client due 
> to wrong `startAfter` parameter.
> For exemple, namenode returns [path1, path2, path3], while router returns 
> [path1, path3, path2] to client. Then client will pass `startAfter` as 
> `path2` at the next iteration, so it will receive `path3` again.
> We need to fix the Router code so that the order of its results is the same 
> as NameNode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to