[ https://issues.apache.org/jira/browse/HDFS-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754399#comment-17754399 ]
ASF GitHub Bot commented on HDFS-17141: --------------------------------------- Hexiaoqiao commented on PR #5925: URL: https://github.com/apache/hadoop/pull/5925#issuecomment-1678411955 > Because the current parameter setting of this method is not optimal Sorry, the core improvement here is that change `isRegularFile(file, true);` to `isRegularFile(file, false);`, right? But I didn't get the performance diff between that. IIUC, both of them need to read file attributions. So why this could improve it, any benchmark result? Thanks. > Optimize the default parameters for the FileUtil.isRegularFile() method > ----------------------------------------------------------------------- > > Key: HDFS-17141 > URL: https://issues.apache.org/jira/browse/HDFS-17141 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Reporter: Liangjun He > Assignee: Liangjun He > Priority: Minor > Labels: pull-request-available > > Optimize the default parameters of the FileUtil.isRegularFile() method to > facilitate direct invocation by more methods. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org