[
https://issues.apache.org/jira/browse/HDFS-17162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756452#comment-17756452
]
ASF GitHub Bot commented on HDFS-17162:
---------------------------------------
simbadzina commented on code in PR #5959:
URL: https://github.com/apache/hadoop/pull/5959#discussion_r1299317526
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/StateStoreService.java:
##########
@@ -64,6 +64,12 @@
* <li>File {@link
*
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreFileImpl
* StateStoreFileImpl}
+ * <li>FileSystem {@link
+ *
org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreFileSystemImpl
+ * StateStoreFileSystemImpl}
Review Comment:
I think we can leave it as it is in your PR. Just as a reference of what
classes are available. The comments in each class can describe the usage.
> RBF: Add missing comments in StateStoreService
> ----------------------------------------------
>
> Key: HDFS-17162
> URL: https://issues.apache.org/jira/browse/HDFS-17162
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: TIsNotT
> Priority: Minor
> Labels: pull-request-available
>
> StateStoreService lacks an introduction to StateStoreFileSystemImpl and
> StateStoreMySQLImpl [link
> HDFS-16943|https://issues.apache.org/jira/projects/HDFS/issues/HDFS-16943?filter=allissues].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
