[ 
https://issues.apache.org/jira/browse/HDFS-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757024#comment-17757024
 ] 

ASF GitHub Bot commented on HDFS-17164:
---------------------------------------

szetszwo opened a new pull request, #5974:
URL: https://github.com/apache/hadoop/pull/5974

   ### Description of PR
   
   During rolling upgrade, datanode create a trash directory for each block 
pool. Then a block deletion becomes moving the block to trash.
   
   For bumpReplicaGS, it will rename the meta file and then continue writing to 
the block file. It should copy the original block file and the original meta 
file to trash in order to support rollback.
   
   See https://issues.apache.org/jira/browse/HDFS-17164
   
   ### How was this patch tested?
   
   Added a new unit test.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ NA ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ NA ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ NA ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   




> During rolling upgrade, datanode should copy-on-append when bumpReplicaGS
> -------------------------------------------------------------------------
>
>                 Key: HDFS-17164
>                 URL: https://issues.apache.org/jira/browse/HDFS-17164
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, rolling upgrades
>            Reporter: Tsz-wo Sze
>            Assignee: Tsz-wo Sze
>            Priority: Major
>
> During rolling upgrade, datanode create a trash directory for each block 
> pool.  Then a block deletion becomes moving the block to trash.
> For bumpReplicaGS, it will rename the meta file and then continue writing to 
> the block file.  It should copy the original block file and the original meta 
> file to trash in order to support rollback.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to