[
https://issues.apache.org/jira/browse/HDFS-17195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765988#comment-17765988
]
ASF GitHub Bot commented on HDFS-17195:
---------------------------------------
teamconfx opened a new pull request, #6089:
URL: https://github.com/apache/hadoop/pull/6089
### Description of PR
When `dfs.encrypt.data.overwrite.downstream.derived.qop` is true,
`org.apache.hadoop.hdfs.server.datanode.DataXceiver#writeBlock` crashes with
NullPointerException. This is because when the configuration is true, the block
key is being obtained from a `datanode.blockPoolTokenSecretManager` that could
still be null.
To reproduce:
1. set `dfs.encrypt.data.overwrite.downstream.derived.qop` to true
2. run
`org.apache.hadoop.hdfs.server.datanode.TestDataXceiverBackwardsCompat#testBackwardsCompat`
This PR provides a fix by making sure the blockPoolTokenSecretManager is not
null while `dfs.encrypt.data.overwrite.downstream.derived.qop` is true.
### How was this patch tested?
Unit test
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under ASF 2.0?
- [ ] If applicable, have you updated the LICENSE, LICENSE-binary,
NOTICE-binary files?
> NullPointerException thrown in DataXceiver when
> `dfs.encrypt.data.overwrite.downstream.derived.qop` is true
> -----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17195
> URL: https://issues.apache.org/jira/browse/HDFS-17195
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.3.6
> Reporter: ConfX
> Priority: Major
> Labels: pull-request-available
>
> When `dfs.encrypt.data.overwrite.downstream.derived.qop` is true,
> `org.apache.hadoop.hdfs.server.datanode.DataXceiver#writeBlock` crashes with
> NullPointerException. This is because when the configuration is true, the
> block key is being obtained from a `datanode.blockPoolTokenSecretManager`
> that could still be null.
> To reproduce:
> 1. set `dfs.encrypt.data.overwrite.downstream.derived.qop` to true
> 2. run
> `org.apache.hadoop.hdfs.server.datanode.TestDataXceiverBackwardsCompat#testBackwardsCompat`
> We created a PR that provides a fix by making sure the
> blockPoolTokenSecretManager is not null while
> `dfs.encrypt.data.overwrite.downstream.derived.qop` is true.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
