[
https://issues.apache.org/jira/browse/HDFS-17196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765990#comment-17765990
]
ASF GitHub Bot commented on HDFS-17196:
---------------------------------------
teamconfx opened a new pull request, #6091:
URL: https://github.com/apache/hadoop/pull/6091
## [HDFS-17196] Overflow during getDatanodeReadTimeout
### Description of PR
https://issues.apache.org/jira/browse/HDFS-17196
Datanode read timeout equals to READ_TIMEOUT_EXTENSION * numNodes +
`dfs.client.socket-timeout`. A large
dfs.client.socket-timeout/numNodes/READ_TIMEOUT_EXTENSION will cause overflow.
To reproduce:
1. set `dfs.client.socket-timeout` to 2147483646
2. run `mvn surefire:test
-Dtest=org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode#testBlocksRemovedWhileInSafeModeEditsArriveFirst`
This PR provides a fix by checking the read timeout calculation is at least
0.
### How was this patch tested?
Unit test
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under ASF 2.0?
- [ ] If applicable, have you updated the LICENSE, LICENSE-binary,
NOTICE-binary files?
> Overflow during getDatanodeReadTimeout
> --------------------------------------
>
> Key: HDFS-17196
> URL: https://issues.apache.org/jira/browse/HDFS-17196
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.3.6
> Reporter: ConfX
> Priority: Major
> Labels: pull-request-available
>
> Datanode read timeout equals to READ_TIMEOUT_EXTENSION * numNodes +
> `dfs.client.socket-timeout`. A large
> dfs.client.socket-timeout/numNodes/READ_TIMEOUT_EXTENSION will cause overflow.
>
> To reproduce:
> 1. set `dfs.client.socket-timeout` to 2147483646
> 2. run `mvn surefire:test
> -Dtest=org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode#testBlocksRemovedWhileInSafeModeEditsArriveFirst`
>
> We create a PR that provides a fix by checking the read timeout calculation
> is at least 0.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
