[ 
https://issues.apache.org/jira/browse/HDFS-17208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769142#comment-17769142
 ] 

ASF GitHub Bot commented on HDFS-17208:
---------------------------------------

Hexiaoqiao commented on code in PR #6109:
URL: https://github.com/apache/hadoop/pull/6109#discussion_r1337102710


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3822,5 +3822,10 @@ public long getLastDirScannerFinishTime() {
   public void setLastDirScannerFinishTime(long time) {
     this.lastDirScannerFinishTime = time;
   }
+
+  @Override
+  public long getPendingAsyncDiskOperations() {

Review Comment:
   `getPendingAsyncDeletions` should be more readable?





> Add the metrics PendingAsyncDiskOperations  in datanode 
> --------------------------------------------------------
>
>                 Key: HDFS-17208
>                 URL: https://issues.apache.org/jira/browse/HDFS-17208
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Haiyang Hu
>            Assignee: Haiyang Hu
>            Priority: Major
>              Labels: pull-request-available
>
> Consider should add  the metrics `PendingAsyncDiskOperations`  to be able to 
> track if we are queueing too many asynchronous disk operations in 
> FsDatasetAsyncDiskService of the datanode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to