[
https://issues.apache.org/jira/browse/HDFS-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769757#comment-17769757
]
ASF GitHub Bot commented on HDFS-17209:
---------------------------------------
ayushtkn commented on code in PR #6110:
URL: https://github.com/apache/hadoop/pull/6110#discussion_r1339112498
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:
##########
@@ -2569,7 +2569,7 @@ public void shutdown() {
if (this.threadGroup != null) {
int sleepMs = 2;
while (true) {
- // When shutting down for restart, wait 2.5 seconds before forcing
+ // When shutting down for restart, wait 1 seconds before forcing
Review Comment:
nit
it should be ``1 second`` not ``1 seconds``
> Correct comments to align with the code
> ---------------------------------------
>
> Key: HDFS-17209
> URL: https://issues.apache.org/jira/browse/HDFS-17209
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.3.6
> Reporter: Yu Wang
> Priority: Trivial
> Labels: pull-request-available
>
> The waiting time in the comments is inconsistent with the code in
> DataNode.java
> {code:java}
> public void shutdown() {
> ...
> while (true) {
> // When shutting down for restart, wait 2.5 seconds before forcing
> // termination of receiver threads.
> if (!this.shutdownForUpgrade ||
> (this.shutdownForUpgrade && (Time.monotonicNow() - timeNotified
> > 1000))) {
> this.threadGroup.interrupt();
> break;
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
