[
https://issues.apache.org/jira/browse/HDFS-17213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770939#comment-17770939
]
ASF GitHub Bot commented on HDFS-17213:
---------------------------------------
slfan1989 commented on PR #6134:
URL: https://github.com/apache/hadoop/pull/6134#issuecomment-1742243467
@xiaojunxiang2023 Thank you for your contribution! But personally, I don't
recommend making this change. It could potentially create some difficulties for
backport code. For instance, some users might be using version 3.1, and if
there are improvements in the CLI in the future, they would have to first
locate this PR and then backport other PRs.
> In RouterAdmin class,"if else" is not as elegant as "switch case".
> ------------------------------------------------------------------
>
> Key: HDFS-17213
> URL: https://issues.apache.org/jira/browse/HDFS-17213
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: xiaojunxiang
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2023-10-01-21-29-22-983.png
>
>
> In RouterAdmin class, "if else" is not as elegant as "switch case" in the
> admin command parameters section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
