[ 
https://issues.apache.org/jira/browse/HDFS-16749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792135#comment-17792135
 ] 

ASF GitHub Bot commented on HDFS-16749:
---------------------------------------

hadoop-yetus commented on PR #6317:
URL: https://github.com/apache/hadoop/pull/6317#issuecomment-1836467335

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 33s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 2 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  42m 52s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   0m 40s |  |  trunk passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |   0m 36s |  |  trunk passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   0m 30s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   0m 42s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   0m 43s |  |  trunk passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 33s |  |  trunk passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +1 :green_heart: |  spotbugs  |   1m 21s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  32m 54s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   0m 32s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 31s |  |  the patch passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |   0m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 30s |  |  the patch passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |   0m 30s |  |  the patch passed  |
   | -1 :x: |  blanks  |   0m  0s | 
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/1/artifact/out/blanks-eol.txt)
 |  The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix 
<<patch_file>>. Refer https://git-scm.com/docs/git-apply  |
   | -0 :warning: |  checkstyle  |   0m 17s | 
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
 |  hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 3 new + 3 
unchanged - 0 fixed = 6 total (was 3)  |
   | +1 :green_heart: |  mvnsite  |   0m 32s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  the patch passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  |  the patch passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | -1 :x: |  spotbugs  |   1m 23s | 
[/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/1/artifact/out/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html)
 |  hadoop-hdfs-project/hadoop-hdfs-rbf generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0)  |
   | +1 :green_heart: |  shadedclient  |  32m 31s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |  22m  2s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
 |  hadoop-hdfs-rbf in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   0m 37s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 144m 57s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | module:hadoop-hdfs-project/hadoop-hdfs-rbf |
   |  |  
org.apache.hadoop.hdfs.server.federation.resolver.FileSubclusterResolver.getMountPointsWithSrc(String,
 SortedMap) makes inefficient use of keySet iterator instead of entrySet 
iterator  At FileSubclusterResolver.java:of keySet iterator instead of entrySet 
iterator  At FileSubclusterResolver.java:[line 184] |
   | Failed junit tests | hadoop.hdfs.server.federation.router.TestRouterRpc |
   |   | hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/6317 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 575e6ad58f8a 5.15.0-86-generic #96-Ubuntu SMP Wed Sep 20 
08:23:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / c0b98fc3d73cbf7902ea917593d3fa86aa70c9e5 |
   | Default Java | Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
   | Multi-JDK versions | 
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 
/usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/1/testReport/ |
   | Max. process+thread count | 3448 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U: 
hadoop-hdfs-project/hadoop-hdfs-rbf |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6317/1/console |
   | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> RBF: Gets the wrong directory information from Trash
> ----------------------------------------------------
>
>                 Key: HDFS-16749
>                 URL: https://issues.apache.org/jira/browse/HDFS-16749
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: rbf
>    Affects Versions: 3.4.0
>            Reporter: Xiping Zhang
>            Assignee: Xiping Zhang
>            Priority: Critical
>              Labels: pull-request-available
>
>  *Liststatus trash path, some directory information that does not exist is 
> returned. Look at the following example:*
> // Current User :zhangxiping
> // router  =》  ns0 ,ns1 
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfsrouteradmin -ls{color}
> Mount Table Entries:
> Source                    Destinations              Owner                     
> Group                     Mode       Quota/Usage
> /user/a                   ns0->/user/a(Priority:0,Readonly:false) zhangxiping 
>               Administrators            rwxr-xr-x  [NsQuota: -/-, SsQuota: 
> -/-]
> /user/b                   ns0->/user/b(Priority:0,Readonly:false) zhangxiping 
>               Administrators            rwxr-xr-x  [NsQuota: -/-, SsQuota: 
> -/-]
> /user/c                   ns0->/user/c(Priority:0,Readonly:false) zhangxiping 
>               Administrators            rwxr-xr-x  [NsQuota: -/-, SsQuota: 
> -/-]
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls hdfs://ns0/user{color}
> Found 4 items
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:17 
> hdfs://ns0/user/a
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:17 
> hdfs://ns0/user/b
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:17 
> hdfs://ns0/user/c
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:11 
> hdfs://ns0/user/zhangxiping
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls hdfs://ns1/user{color}
> ls: `hdfs://ns1/user': No such file or directory
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls 
> hdfs://ns0/user/zhangxiping/.Trash/Current/user{color}
> Found 1 items
> drwxr-xr-x   - zhangxiping supergroup          0 2022-10-18 10:14 
> hdfs://ns0/user/zhangxiping/.Trash/Current/user/d
> {*}\project\hadoop3.3.0{*}>{color:#ff0000}hdfs dfs -ls 
> /user/zhangxiping/.Trash/Current/user      //Requests to the router{color}
> Found 4 items
> drwxrwxrwx   - zhangxiping supergroup          0 1970-01-01 08:00 
> /user/zhangxiping/.Trash/Current/user/a  
> {color:#00875a}drwxrwxrwx   - zhangxiping supergroup          0 1970-01-01 
> 08:00 /user/zhangxiping/.Trash/Current/user/b{color}
> {color:#00875a}drwxrwxrwx   - zhangxiping supergroup          0 1970-01-01 
> 08:00 /user/zhangxiping/.Trash/Current/user/c    *//The records on it 
> shouldn't exist*{color}
> drwxr-xr-x     - zhangxiping supergroup          0 2022-10-18 10:14 
> /user/zhangxiping/.Trash/Current/user/d



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to