[
https://issues.apache.org/jira/browse/HDFS-17269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793629#comment-17793629
]
ASF GitHub Bot commented on HDFS-17269:
---------------------------------------
LiuGuH commented on code in PR #6312:
URL: https://github.com/apache/hadoop/pull/6312#discussion_r1417093166
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java:
##########
@@ -282,6 +282,13 @@ public void testMultipleMountPoint() throws IOException,
fileStatuses = fs.listStatus(new Path("/user/test-trash/.Trash/Current/" +
MOUNT_POINT2));
assertEquals(0, fileStatuses.length);
+ // In ns1, make a trash path with timestamp to simulate a trash path.
+ String trashPath = "/user/test-trash/.Trash/" + System.currentTimeMillis();
+ client1.mkdirs(trashPath, new FsPermission("770"),
+ true);
+ fileStatuses = fs.listStatus(new Path("/user/test-trash/.Trash"));
Review Comment:
Thanks for reivew. For this it is enough and others will be more
complicated.
> RBF: Listing trash directory should return subdirs from all subclusters.
> ------------------------------------------------------------------------
>
> Key: HDFS-17269
> URL: https://issues.apache.org/jira/browse/HDFS-17269
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: liuguanghua
> Assignee: liuguanghua
> Priority: Minor
> Labels: pull-request-available
>
> Same scenario as HDFS-17263
> If user trash config fs.trash.checkpoint.interval set to 10min in namenodes,
> the trash root dir /user/$USER/.Trash/Current will be very 10 min renamed to
> /user/$USER/.Trash/timestamp .
>
> When user ls /user/$USER/.Trash, it should be return blow:
> /user/$USER/.Trash/Current
> /user/$USER/.Trash/timestamp (This is invisible now)
>
> So we should make that user ls trash root dir can see all trash subdirs in
> all nameservices which user has any mountpoint in nameservice.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
