[
https://issues.apache.org/jira/browse/HDFS-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200825#comment-13200825
]
Eli Collins commented on HDFS-2868:
-----------------------------------
Looks good Harsh.
Nits:
- I'd make the comment "@Override // DataNodeMXBean" to match all the others
- In TestDataNodeMXBean.java can drop the comment since it says what the
following line does (in general comments should say "why" rather than "what" if
the "what" is clear
- In getXceiverCount perhaps replace "Gets the live count of transfer threads
on the Datanode" with "Returns an estimate of the number of Datanode threads
actively transferring blocks".
> Add number of active transfer threads to the DataNode status
> ------------------------------------------------------------
>
> Key: HDFS-2868
> URL: https://issues.apache.org/jira/browse/HDFS-2868
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node
> Affects Versions: 0.23.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: HDFS-2868.patch
>
>
> Presently, we do not provide any stats from the DN that specifically
> indicates the total number of active transfer threads (xceivers). Having such
> a metric can be very helpful as well, over plain num-ops(type) form of
> metrics, which already exist.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
