[ 
https://issues.apache.org/jira/browse/HDFS-17289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17797167#comment-17797167
 ] 

ASF GitHub Bot commented on HDFS-17289:
---------------------------------------

zhangshuyan0 commented on code in PR #6357:
URL: https://github.com/apache/hadoop/pull/6357#discussion_r1427941430


##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java:
##########
@@ -368,14 +368,14 @@ private DFSOutputStream(DFSClient dfsClient, String src,
     }
   }
 
-  private void adjustPacketChunkSize(HdfsFileStatus stat) throws IOException{
+  private void adjustPacketChunkSize(LocatedBlock lastBlock) throws 
IOException{
 
-    long usedInLastBlock = stat.getLen() % blockSize;
+    long usedInLastBlock = lastBlock.getBlockSize() % blockSize;

Review Comment:
   Why don't we use `long usedInLastBlock = lastBlock.getBlockSize()` directly?





> Should not consider the size of non-lastBlocks equals to complete block size.
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-17289
>                 URL: https://issues.apache.org/jira/browse/HDFS-17289
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.3.6
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to