[ 
https://issues.apache.org/jira/browse/HDFS-17294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798205#comment-17798205
 ] 

ASF GitHub Bot commented on HDFS-17294:
---------------------------------------

tasanuma commented on code in PR #6366:
URL: https://github.com/apache/hadoop/pull/6366#discussion_r1430132571


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -2673,6 +2677,24 @@ String reconfigureSlowNodesParameters(final 
DatanodeManager datanodeManager,
         datanodeManager.setMaxSlowPeersToReport(maxSlowPeersToReport);
         break;
       }
+      case DFS_NAMENODE_SLOWPEER_COLLECT_INTERVAL_KEY: {
+        if (newVal == null) {
+          // set to the value of the current system or default
+          long defaultInterval =
+              
getConf().getTimeDuration(DFS_NAMENODE_SLOWPEER_COLLECT_INTERVAL_KEY,
+                  DFS_NAMENODE_SLOWPEER_COLLECT_INTERVAL_DEFAULT, 
TimeUnit.MILLISECONDS);
+          datanodeManager.restartSlowPeerCollector(defaultInterval);
+          result = DFS_NAMENODE_SLOWPEER_COLLECT_INTERVAL_DEFAULT;

Review Comment:
   Maybe this is the correct line?
   ```suggestion
             result = Long.toString(defaultInterval);
   ```





> Reconfigure the scheduling cycle of the slowPeerCollectorDaemon thread.
> -----------------------------------------------------------------------
>
>                 Key: HDFS-17294
>                 URL: https://issues.apache.org/jira/browse/HDFS-17294
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: huangzhaobo99
>            Assignee: huangzhaobo99
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to