[
https://issues.apache.org/jira/browse/HDFS-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798397#comment-17798397
]
ASF GitHub Bot commented on HDFS-17290:
---------------------------------------
simbadzina commented on code in PR #6359:
URL: https://github.com/apache/hadoop/pull/6359#discussion_r1430796400
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:
##########
@@ -342,6 +344,14 @@ public void incrClientBackoff() {
rpcClientBackoff.incr();
}
+ /**
+ * Client was backoff due to disconnection
Review Comment:
Is this the other way around, the client ended up being disconnected due to
backoffs?
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -3133,6 +3133,13 @@ private void internalQueueCall(Call call, boolean
blocking)
// For example, IPC clients using FailoverOnNetworkExceptionRetry handle
// RetriableException.
rpcMetrics.incrClientBackoff();
+ // Clients that are directly put into lowest priority queue are backoff
and disconnected.
Review Comment:
Nit-> tense. backed off.
> HDFS: add client rpc backoff metrics due to disconnection from lowest
> priority queue
> ------------------------------------------------------------------------------------
>
> Key: HDFS-17290
> URL: https://issues.apache.org/jira/browse/HDFS-17290
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.10.0, 3.4.0
> Reporter: Lei Yang
> Assignee: Lei Yang
> Priority: Major
> Labels: pull-request-available
>
> Clients are backoff when rpcs cannot be enqueued. However there are different
> scenarios when backoff could happen. Currently there is no way to
> differenciate whether a backoff happened due to lowest prio+disconnection or
> queue overflow from higher priority queues when connection between client and
> namenode remains open. Currently IPC server just emits a single metrics for
> all the backoffs.
> Example:
> # Client are directly enqueued into lowest priority queue and backoff when
> lowest queue is full. Client are expected to disconnect from namenode.
> # Client are enqueued into non-lowest priority queue and overflowed all the
> way down to lowest priority queue and back off. In this case, connection
> between client and namenode remains open.
> We would like to add metrics for #1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
