[
https://issues.apache.org/jira/browse/HDFS-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800235#comment-17800235
]
ASF GitHub Bot commented on HDFS-17056:
---------------------------------------
ayushtkn commented on code in PR #6379:
URL: https://github.com/apache/hadoop/pull/6379#discussion_r1435934137
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/ECAdmin.java:
##########
@@ -642,6 +642,10 @@ public int run(Configuration conf, List<String> args)
throws IOException {
throw e;
}
} else {
+ if (args.size() > 0) {
+ System.err.println(getName() + ": Too many arguments");
Review Comment:
If you pass multiple policies, that means you want a combined result, like
if all these are supported or not in the "cluster", if you want one policy,
pass one policy only.
The whole design is to verify things at cluster level, not at policy level.
To highlight cluster level setup issues, like all the enabled policies aren't
supported & things like that, it was created for cluster admin level usage.
you can add an additional option which tells the result per policy if the
additional option is provided, in that case post getting the result, it can
loop over the policies and get individual result, changing proto & all is like
last things to do, but I don't think it is required as of now.
> EC: Fix verifyClusterSetup output in case of an invalid param.
> --------------------------------------------------------------
>
> Key: HDFS-17056
> URL: https://issues.apache.org/jira/browse/HDFS-17056
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ec
> Reporter: Ayush Saxena
> Assignee: huangzhaobo99
> Priority: Major
> Labels: newbie, pull-request-available
>
> {code:java}
> bin/hdfs ec -verifyClusterSetup XOR-2-1-1024k
> 9 DataNodes are required for the erasure coding policies: RS-6-3-1024k,
> XOR-2-1-1024k. The number of DataNodes is only 3. {code}
> verifyClusterSetup requires -policy then the name of policies, else it
> defaults to all enabled policies.
> In case there are additional invalid options it silently ignores them, unlike
> other EC commands which throws out Too Many Argument exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
