[ 
https://issues.apache.org/jira/browse/HDFS-17335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805866#comment-17805866
 ] 

ASF GitHub Bot commented on HDFS-17335:
---------------------------------------

hfutatzhanghb commented on PR #6431:
URL: https://github.com/apache/hadoop/pull/6431#issuecomment-1888362422

   I think the checkstyle warnings can be ignored. 
   @Hexiaoqiao @tomscut @tasanuma  Sir, could you please take a look at this 
PR? Thanks a lot.




> Add metrics for syncWaitQ in FSEditLogAsync
> -------------------------------------------
>
>                 Key: HDFS-17335
>                 URL: https://issues.apache.org/jira/browse/HDFS-17335
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.3.6
>            Reporter: farmmamba
>            Assignee: farmmamba
>            Priority: Minor
>              Labels: pull-request-available
>
> To monitor syncWaitQ in FSEditLogAsync, we add a metric syncPendingCount.
> The reason we add this metrics is that when dequeueEdit() return null,  the 
> boolean variable doSync is set to {color:#0747a6}+!syncWaitQ.isEmpty()+    
> {color:#172b4d}After adding this metrics we can better monitor sync 
> performance and codes.{color}{color}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to