[
https://issues.apache.org/jira/browse/HDFS-17324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806598#comment-17806598
]
ASF GitHub Bot commented on HDFS-17324:
---------------------------------------
LiuGuH commented on code in PR #6412:
URL: https://github.com/apache/hadoop/pull/6412#discussion_r1451883398
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestObserverWithRouter.java:
##########
@@ -599,9 +604,6 @@ public void testRouterResponseHeaderState() {
namespaceIdMap.put("ns2", new LongAccumulator(Math::max, Long.MIN_VALUE));
Map<String, Long> mockMapping = new HashMap<>();
- mockMapping.put("ns0", 10L);
- mockMapping.put("ns2", 100L);
- mockMapping.put("ns3", Long.MIN_VALUE);
Review Comment:
Var mockMapping should be removed . Because
routerStateIdContext.updateResponseState(responseHeaderBuilder) will update
RouterFederatedState with namespaceIdMap's keys and values that meet the
requirements.
Thanks
> RBF: Router should not return nameservices that not enable observer read in
> RpcResponseHeaderProto
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-17324
> URL: https://issues.apache.org/jira/browse/HDFS-17324
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: liuguanghua
> Assignee: liuguanghua
> Priority: Major
> Labels: pull-request-available
>
> {color:#172b4d}Router Observer Read is controled by
> RBFConfigKeys.DFS_ROUTER_OBSERVER_READ_DEFAULT_KEY and
> RBFConfigKeys.DFS_ROUTER_OBSERVER_READ_OVERRIDES.{color}
> {color:#172b4d}If nameservice is not enable for observer read in Router,
> RpcResponseHeaderProto in Router should not return it.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
