[
https://issues.apache.org/jira/browse/HDFS-17357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811133#comment-17811133
]
ASF GitHub Bot commented on HDFS-17357:
---------------------------------------
LiuGuH opened a new pull request, #6502:
URL: https://github.com/apache/hadoop/pull/6502
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
JIRA: [HDFS-17357](https://issues.apache.org/jira/browse/HDFS-17357)
NioInetPeer.close() now do not close socket connection.
In my environment，all data were stored with EC.
And I found 3w+ connections leakage in datanode . And I found many warn
message as blew.
2024-01-22 15:27:57,500 WARN
org.apache.hadoop.hdfs.server.datanode.DataNode:
hostname:50010:DataXceiverServer
When any Exception is found in DataXceiverServer, it will execute
clostStream.
IOUtils.closeStream(peer) -> Peer.close() -> NioInetPeer.close()
But NioInetPeer.close() is not invoked with close socket connection. And
this will lead to connection leakage.
And Other subClass of Peer's close() is implemented with socket.close().
See EncryptedPeer, DomainPeer, BasicInetPeer
### How was this patch tested?
> NioInetPeer.close() should close socket connection.
> ---------------------------------------------------
>
> Key: HDFS-17357
> URL: https://issues.apache.org/jira/browse/HDFS-17357
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: liuguanghua
> Assignee: liuguanghua
> Priority: Major
>
> NioInetPeer.close() now do not close socket connection.
>
> In my environment，all data were stored with EC.
> And I found 3w+ connections leakage in datanode . And I found many warn
> message as blew.
> 2024-01-22 15:27:57,500 WARN org.apache.hadoop.hdfs.server.datanode.DataNode:
> hostname:50010:DataXceiverServer
>
> When any Exception is found in DataXceiverServer, it will execute clostStream.
> IOUtils.closeStream(peer) -> Peer.close() -> NioInetPeer.close()
> But NioInetPeer.close() is not invoked with close socket connection. And
> this will lead to connection leakage.
> Other subClass of Peer's close() is implemented with socket.close(). See
> EncryptedPeer, DomainPeer, BasicInetPeer
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
