[ 
https://issues.apache.org/jira/browse/HDFS-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811846#comment-17811846
 ] 

ASF GitHub Bot commented on HDFS-17353:
---------------------------------------

ssanchozz commented on code in PR #6491:
URL: https://github.com/apache/hadoop/pull/6491#discussion_r1469489965


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##########
@@ -2074,9 +2074,6 @@ public void testMkdirsWithCallerContext() throws 
IOException {
     GenericTestUtils.LogCapturer auditlog =
         GenericTestUtils.LogCapturer.captureLogs(FSNamesystem.AUDIT_LOG);
 
-    // Current callerContext is null
-    assertNull(CallerContext.getCurrent());

Review Comment:
   I thought it's quite strange to check that CallerContext is null and reset 
it next line. But in testRealUserPropagationInCallerContext it is not reset, 
so, agree to revert this.





> Fix failing RBF module tests
> ----------------------------
>
>                 Key: HDFS-17353
>                 URL: https://issues.apache.org/jira/browse/HDFS-17353
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Alexander Bogdanov
>            Priority: Major
>              Labels: pull-request-available
>
> 3 tests are failing in RBF module:
>  *  TestRouterRpcMultiDestination.testCallerContextWithMultiDestinations
>  * TestRouterRpcMultiDestination>TestRouterRpc.testMkdirsWithCallerContext
>  * 
> TestRouterRpcMultiDestination>TestRouterRpc.testRealUserPropagationInCallerContext
> Need to fix them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to