[
https://issues.apache.org/jira/browse/HDFS-17404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822728#comment-17822728
]
ASF GitHub Bot commented on HDFS-17404:
---------------------------------------
ctrezzo commented on code in PR #6598:
URL: https://github.com/apache/hadoop/pull/6598#discussion_r1509687361
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java:
##########
@@ -221,12 +225,16 @@ private synchronized void removeExpiredKeys() {
/**
* Set block keys, only to be used in worker mode
*/
- public synchronized void addKeys(ExportedBlockKeys exportedKeys)
+ public synchronized void addKeys(ExportedBlockKeys exportedKeys,
Optional<InetSocketAddress> nnAddr)
throws IOException {
if (isMaster || exportedKeys == null) {
return;
}
- LOG.info("Setting block keys. BlockPool = {} .", blockPoolId);
+ if (nnAddr.isPresent()) {
+ LOG.info("Setting block keys. BlockPool = {} . Namenode Address = {} .",
blockPoolId, nnAddr);
Review Comment:
Can we pass the BPServiceActor instead? That way you can print the hostname
as well as the state. This will display whether or not it was the
active/standby/observer when the request happened. This could be useful
debugging information.
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockPoolTokenSecretManager.java:
##########
@@ -36,7 +38,7 @@
*/
public class BlockPoolTokenSecretManager extends
SecretManager<BlockTokenIdentifier> {
-
Review Comment:
Can you go through all the files and remove the changes that do not pertain
to the lines modified by this patch?
> Add Namenode info to log message when setting block keys
> --------------------------------------------------------
>
> Key: HDFS-17404
> URL: https://issues.apache.org/jira/browse/HDFS-17404
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Joseph Dell'Aringa
> Priority: Trivial
> Labels: pull-request-available
>
> An issue occurred and it was not clear which NN HA instance had failed to
> update the blocks since the current logging in the DN logs doesn't have the
> details. This is a tracking jira to improving logging so we can quickly
> Identify which NN has failed to rotate block key.
> ex log:
> {code:java}
> 2024-01-23 01:32:39,736 INFO
> org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager: Setting
> block keys{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
