[ 
https://issues.apache.org/jira/browse/HDFS-17404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823275#comment-17823275
 ] 

ASF GitHub Bot commented on HDFS-17404:
---------------------------------------

Jtdellaringa commented on code in PR #6598:
URL: https://github.com/apache/hadoop/pull/6598#discussion_r1511568416


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/BlockTokenSecretManager.java:
##########
@@ -226,7 +228,7 @@ public synchronized void addKeys(ExportedBlockKeys 
exportedKeys)
     if (isMaster || exportedKeys == null) {
       return;
     }
-    LOG.info("Setting block keys. BlockPool = {} .", blockPoolId);
+    LOG.info("Setting block keys. BlockPool = {} . NamenodeIndex = {} .", 
blockPoolId, nnIndex);

Review Comment:
   Decided not to pass BPServiceActor due to it being a private class. Namenode 
address will instead be logged when dn received command from standby or active 
nn





> Record the BPServiceActor information that communicates with Active
> -------------------------------------------------------------------
>
>                 Key: HDFS-17404
>                 URL: https://issues.apache.org/jira/browse/HDFS-17404
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Joseph Dell'Aringa
>            Priority: Trivial
>              Labels: pull-request-available
>
> When BPServiceActor communicates with an active nn we should record the nn 
> address. This information is already available for standby nn.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to