[
https://issues.apache.org/jira/browse/HDFS-17388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827922#comment-17827922
]
ASF GitHub Bot commented on HDFS-17388:
---------------------------------------
ferhui commented on code in PR #6589:
URL: https://github.com/apache/hadoop/pull/6589#discussion_r1528016536
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java:
##########
Review Comment:
seems that only changed the testing methods. Is it expected?
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -3699,7 +3702,7 @@ void fsync(String src, long fileId, String clientName,
long lastBlockLength)
}
FSDirWriteFileOp.persistBlocks(dir, src, pendingFile, false);
} finally {
- writeUnlock("fsync");
+ writeUnlock(FSNamesystemLockMode.GLOBAL, "fsync");
Review Comment:
Why use Global lock here for fsync? found that it only checks FS lock in
following codes.
> [FGL] Client RPCs involving write process supports fine-grained lock
> --------------------------------------------------------------------
>
> Key: HDFS-17388
> URL: https://issues.apache.org/jira/browse/HDFS-17388
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> The client write process involves many client RPCs.
>
> This ticket is used to make these RPCs support fine-grained lock.
> * mkdir
> * create
> * addBlock
> * abandonBlock
> * getAdditionalDatanode
> * updateBlockForPipeline
> * updatePipeline
> * fsync
> * complete
> * rename
> * rename2
> * append
> * renewLease
> * recoverLease
> * delete
> * createSymlink
> * renewDelegationToken
> * cancelDelegationToken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
