[ 
https://issues.apache.org/jira/browse/HDFS-17417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830030#comment-17830030
 ] 

ASF GitHub Bot commented on HDFS-17417:
---------------------------------------

huangzhaobo99 commented on code in PR #6656:
URL: https://github.com/apache/hadoop/pull/6656#discussion_r1536571168


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -8713,7 +8714,7 @@ void removeXAttr(String src, XAttr xAttr, boolean 
logRetryCache)
 
   @Override
   public void removeXattr(long id, String xattrName) throws IOException {
-    writeLock();
+    writeLock(FSNamesystemLockMode.FS);

Review Comment:
   Hi @ZanderXu sir, removeXAttr RPC seems unrelated to PR title.





> [FGL] HeartbeatManager and DatanodeAdminMonitor support fine-grained lock
> -------------------------------------------------------------------------
>
>                 Key: HDFS-17417
>                 URL: https://issues.apache.org/jira/browse/HDFS-17417
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: ZanderXu
>            Assignee: ZanderXu
>            Priority: Major
>              Labels: pull-request-available
>
> [FGL] Monitor in HeartbeatManager supports fine-grained lock.
>  
> [FGL] DatanodeAdminMonitor supports fine-grained locking.
>  * DatanodeAdminBackoffMonitor
>  * DatanodeAdminDefaultMonitor



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to