[
https://issues.apache.org/jira/browse/HDFS-17412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830827#comment-17830827
]
ASF GitHub Bot commented on HDFS-17412:
---------------------------------------
ferhui commented on code in PR #6667:
URL: https://github.com/apache/hadoop/pull/6667#discussion_r1538715428
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -2004,13 +2004,14 @@ void metaSave(String filename) throws IOException {
out.close();
}
} finally {
- readUnlock(operationName, getLockReportInfoSupplier(null));
+ readUnlock(FSNamesystemLockMode.GLOBAL, operationName,
getLockReportInfoSupplier(null));
}
logAuditEvent(true, operationName, null);
}
private void metaSave(PrintWriter out) {
- assert hasReadLock();
+ assert hasReadLock(FSNamesystemLockMode.GLOBAL);
+ // Normally FSReadLock is needed here, but I think thread-safe is
unnecessary here.
Review Comment:
Can add TODO or remove opinions here?
Or create another ticket to track it as an improvement?
> [FGL] Client RPCs involving maintenance supports fine-grained lock
> ------------------------------------------------------------------
>
> Key: HDFS-17412
> URL: https://issues.apache.org/jira/browse/HDFS-17412
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> There are multiple client RPCs that used for admin to maintain cluster.
>
> This ticket is used to make these RPCs supporting fine-grained lock.
> * getDatanodeReport
> * getDatanodeStorageReport
> * saveNamespace
> * metaSave
> * rollEdits
> * restoreFailedStorage
> * finalizeUpgrade
> * rollingUpgrade
> * getSlowDatanodeReport
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
