[
https://issues.apache.org/jira/browse/HDFS-17444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832698#comment-17832698
]
ASF GitHub Bot commented on HDFS-17444:
---------------------------------------
xiaojunxiang2023 commented on code in PR #6694:
URL: https://github.com/apache/hadoop/pull/6694#discussion_r1545922274
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java:
##########
@@ -40,30 +33,27 @@
import org.apache.hadoop.metrics2.util.MBeans;
import org.apache.hadoop.net.NetUtils;
import org.apache.hadoop.security.SecurityUtil;
+import org.apache.hadoop.thirdparty.com.google.common.base.Strings;
+import org.apache.hadoop.thirdparty.com.google.common.collect.Maps;
import org.apache.hadoop.tracing.TraceUtils;
-import org.apache.hadoop.util.DiskChecker;
-
-import static
org.apache.hadoop.hdfs.DFSConfigKeys.DFS_JOURNALNODE_HTTP_BIND_HOST_KEY;
-import static org.apache.hadoop.util.ExitUtil.terminate;
-import static org.apache.hadoop.util.Time.now;
-import org.apache.hadoop.util.StringUtils;
-import org.apache.hadoop.util.Tool;
-import org.apache.hadoop.util.ToolRunner;
import org.apache.hadoop.tracing.Tracer;
+import org.apache.hadoop.util.*;
import org.eclipse.jetty.util.ajax.JSON;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import javax.management.ObjectName;
import java.io.File;
import java.io.FileFilter;
import java.io.IOException;
import java.net.InetSocketAddress;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
Review Comment:
ok, I will correct it, thanks
> Add getJournalSyncerStatus jmx metrics, to Indicates whether the
> JournalSyncer thread for the every namespace has enter working state.
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-17444
> URL: https://issues.apache.org/jira/browse/HDFS-17444
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.3.4, 3.3.6
> Reporter: xiaojunxiang
> Assignee: xiaojunxiang
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2024-03-31-09-31-18-056.png
>
>
> The JornalNode JVM process is not immediately in a normal state until the
> JournalSyncer thread is started.
> For some management platforms such as Ambari rolling restart JournalNode, we
> need a jmx metric to determine whether the JournalSyncer thread is started
> and enter working state for current namespace before restarting the next
> JournalNode. Otherwise, restart too quickly and more than half of
> JournalNodes will be out of order, causing the NameNode to die.
> When i add it , the effect is as follows:
> !image-2024-03-31-09-31-18-056.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
