[
https://issues.apache.org/jira/browse/HDFS-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838432#comment-17838432
]
ASF GitHub Bot commented on HDFS-17457:
---------------------------------------
ferhui commented on code in PR #6741:
URL: https://github.com/apache/hadoop/pull/6741#discussion_r1569812780
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestNameNodePrunesMissingStorages.java:
##########
@@ -22,6 +22,7 @@
import java.util.ArrayList;
import java.util.Collection;
+import org.apache.hadoop.hdfs.server.namenode.fgl.FSNamesystemLockMode;
Review Comment:
And here.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDNFencing.java:
##########
@@ -582,13 +583,13 @@ private void banner(String string) {
}
private void doMetasave(NameNode nn2) {
- nn2.getNamesystem().writeLock();
+ nn2.getNamesystem().writeLock(FSNamesystemLockMode.GLOBAL);
Review Comment:
seem BM lock here?
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestAddBlockRetry.java:
##########
@@ -24,6 +24,8 @@
import static org.junit.Assert.assertTrue;
import java.io.IOException;
import java.util.EnumSet;
+
+import org.apache.hadoop.hdfs.server.namenode.fgl.FSNamesystemLockMode;
Review Comment:
Can more it near other hdfs packages(org.apache.hadoop.hdfs.server.xx)?
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeleteRace.java:
##########
@@ -29,6 +29,7 @@
import java.util.concurrent.Semaphore;
import org.apache.hadoop.fs.Options;
+import org.apache.hadoop.hdfs.server.namenode.fgl.FSNamesystemLockMode;
Review Comment:
here
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLogRace.java:
##########
@@ -41,6 +41,8 @@
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Supplier;
+
+import org.apache.hadoop.hdfs.server.namenode.fgl.FSNamesystemLockMode;
Review Comment:
and here
> [FGL] UTs support fine-grained locking
> --------------------------------------
>
> Key: HDFS-17457
> URL: https://issues.apache.org/jira/browse/HDFS-17457
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> [FGL] UTs support fine-grained locking
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
