[ 
https://issues.apache.org/jira/browse/HDFS-17446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840478#comment-17840478
 ] 

ASF GitHub Bot commented on HDFS-17446:
---------------------------------------

hadoop-yetus commented on PR #6685:
URL: https://github.com/apache/hadoop/pull/6685#issuecomment-2075182513

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m 01s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  spotbugs  |   0m 00s |  |  spotbugs executables are not 
available.  |
   | +0 :ok: |  codespell  |   0m 00s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m 00s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m 00s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m 00s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  | 114m 45s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   8m 34s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   6m 44s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   9m 03s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m 22s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  | 191m 29s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   6m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   5m 05s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   5m 05s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m 01s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   3m 23s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   5m 46s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   4m 52s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  | 217m 47s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   8m 26s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 563m 21s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | GITHUB PR | https://github.com/apache/hadoop/pull/6685 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | MINGW64_NT-10.0-17763 da27b6e6c2af 3.4.10-87d57229.x86_64 
2024-02-14 20:17 UTC x86_64 Msys |
   | Build tool | maven |
   | Personality | /c/hadoop/dev-support/bin/hadoop.sh |
   | git revision | trunk / 150f9834c98b60a1d0013945927a007d22280259 |
   | Default Java | Azul Systems, Inc.-1.8.0_332-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6685/1/testReport/
 |
   | modules | C: hadoop-hdfs-project/hadoop-hdfs U: 
hadoop-hdfs-project/hadoop-hdfs |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6685/1/console
 |
   | versions | git=2.44.0.windows.1 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> The DataNode adds a log to report its progress during addToReplicasMap 
> execution.
> ---------------------------------------------------------------------------------
>
>                 Key: HDFS-17446
>                 URL: https://issues.apache.org/jira/browse/HDFS-17446
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: xiaojunxiang
>            Priority: Critical
>              Labels: pull-request-available
>         Attachments: image-2024-03-28-23-53-29-057.png, 
> image-2024-04-01-17-26-05-433.png
>
>
> Datanodes do not print logs when addToReplicasMap is just started, so we will 
> not be aware of its progress, or even wait up to 4 hours for a large cluster. 
> This is very confusing.
> A cluster is as follows:
> !image-2024-03-28-23-53-29-057.png!
>  
> The optimized result is as follows:
> (Because Scan thread is ForkJoinPool, so the printing may be repeated, but it 
> will affect the overall progress of the presentation
> )
> !image-2024-04-01-17-26-05-433.png!
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to