[ 
https://issues.apache.org/jira/browse/HDFS-17502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841476#comment-17841476
 ] 

ASF GitHub Bot commented on HDFS-17502:
---------------------------------------

yuw1 opened a new pull request, #6777:
URL: https://github.com/apache/hadoop/pull/6777

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   The current log format of printStatistics() is:
   ```
   2024-04-27 21:15:05,429 [main] INFO  namenode.FSEditLog 
(FSEditLog.java:printStatistics(801)) - Number of transactions: 2 Total time 
for transactions(ms): 2 Number of transactions batched in Syncs: 0 Number of 
syncs: 3 SyncTimes(ms): 1 0
   ```
   There are no separators between different keys, making it difficult to read. 
The modified format is:
   ```
   2024-04-27 21:15:05,429 [main] INFO  namenode.FSEditLog 
(FSEditLog.java:printStatistics(801)) - Number of transactions: 2, Total time 
for transactions(ms): 2, Number of transactions batched in Syncs: 0, Number of 
syncs: 3, SyncTimes(ms): 1 0 
   ```
   
   ### How was this patch tested?
   This patch only updates the log format and does not need to add new test 
cases.
   
   
   ### For code changes:
   
   - [x] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> Adjust the log format of the printStatistics() in FSEditLog.java
> ----------------------------------------------------------------
>
>                 Key: HDFS-17502
>                 URL: https://issues.apache.org/jira/browse/HDFS-17502
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namanode
>            Reporter: Yu Wang
>            Priority: Trivial
>
> The current log format of printStatistics() is:
> {code:java}
> 2024-04-27 21:15:05,429 [main] INFO  namenode.FSEditLog 
> (FSEditLog.java:printStatistics(801)) - Number of transactions: 2 Total time 
> for transactions(ms): 2 Number of transactions batched in Syncs: 0 Number of 
> syncs: 3 SyncTimes(ms): 1 0{code}
> There are no separators between different keys, making it difficult to read. 
> The modified format is:
> {code:java}
> 2024-04-27 21:15:05,429 [main] INFO  namenode.FSEditLog 
> (FSEditLog.java:printStatistics(801)) - Number of transactions: 2, Total time 
> for transactions(ms): 2, Number of transactions batched in Syncs: 0, Number 
> of syncs: 3, SyncTimes(ms): 1 0 {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to