[
https://issues.apache.org/jira/browse/HDFS-17508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842180#comment-17842180
]
ASF GitHub Bot commented on HDFS-17508:
---------------------------------------
dannytbecker opened a new pull request, #6783:
URL: https://github.com/apache/hadoop/pull/6783
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
When the MembershipStore refreshes its cache, it will also call the
overrideExpiredRecords() method, which will write the Expired state back to the
state store. Due to a race condition this logic can overwrite valid records.
overrideExpiredRecords should first check if the state of the record is already
set to "EXPIRED" before it writes the record to the state store.
### How was this patch tested?
Added unit test
"TestStateStoreMembershipState#testRegistrationExpiredRaceCondition"
### For code changes:
- [X] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> RBF: MembershipStateStore can overwrite valid records when refreshing the
> local cache
> -------------------------------------------------------------------------------------
>
> Key: HDFS-17508
> URL: https://issues.apache.org/jira/browse/HDFS-17508
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf
> Affects Versions: 3.3.4
> Reporter: Danny Becker
> Priority: Major
>
> When the MembershipStore refreshes its cache, it will also call the
> overrideExpiredRecords() method, which will write the Expired state back to
> the state store. Due to a race condition this logic can overwrite valid
> records. overrideExpiredRecords should first check if the state of the record
> is already set to "EXPIRED" before it writes the record to the state store.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
