[
https://issues.apache.org/jira/browse/HDFS-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844079#comment-17844079
]
ASF GitHub Bot commented on HDFS-17464:
---------------------------------------
haiyang1987 commented on code in PR #6724:
URL: https://github.com/apache/hadoop/pull/6724#discussion_r1591717049
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -2028,7 +2028,7 @@ private ReplicaInfo finalizeReplica(String bpid,
ReplicaInfo replicaInfo)
} else {
FsVolumeImpl v = (FsVolumeImpl)replicaInfo.getVolume();
if (v == null) {
- throw new IOException("No volume for block " + replicaInfo);
+ throw new IOException("No volume for bpid: " + bpid + " , block: " +
replicaInfo);
Review Comment:
throw new IOException("No volume for bpid: " + bpid + ", block: "
+ replicaInfo);
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -2016,7 +2016,7 @@ private ReplicaInfo finalizeReplica(String bpid,
ReplicaInfo replicaInfo)
if (volumeMap.get(bpid, replicaInfo.getBlockId()).getGenerationStamp()
> replicaInfo.getGenerationStamp()) {
throw new IOException("Generation Stamp should be monotonically "
- + "increased.");
+ + "increased. bpid: " + bpid + " , block: " + replicaInfo);
Review Comment:
"increased bpid: " + bpid + ", block: " + replicaInfo);
> Improve some logs output in class FsDatasetImpl
> -----------------------------------------------
>
> Key: HDFS-17464
> URL: https://issues.apache.org/jira/browse/HDFS-17464
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.4.0
> Reporter: farmmamba
> Assignee: farmmamba
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
