[ https://issues.apache.org/jira/browse/HDFS-17526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17846234#comment-17846234 ]
ASF GitHub Bot commented on HDFS-17526: --------------------------------------- hadoop-yetus commented on PR #6826: URL: https://github.com/apache/hadoop/pull/6826#issuecomment-2109685586 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 00s | | No case conflicting files found. | | +0 :ok: | spotbugs | 0m 00s | | spotbugs executables are not available. | | +0 :ok: | codespell | 0m 01s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 01s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 00s | | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 00s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 91m 52s | | trunk passed | | +1 :green_heart: | compile | 6m 52s | | trunk passed | | +1 :green_heart: | checkstyle | 5m 03s | | trunk passed | | +1 :green_heart: | mvnsite | 7m 02s | | trunk passed | | +1 :green_heart: | javadoc | 6m 05s | | trunk passed | | +1 :green_heart: | shadedclient | 155m 06s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 43s | | the patch passed | | +1 :green_heart: | compile | 3m 35s | | the patch passed | | +1 :green_heart: | javac | 3m 35s | | the patch passed | | +1 :green_heart: | blanks | 0m 00s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 2m 21s | | the patch passed | | +1 :green_heart: | mvnsite | 4m 15s | | the patch passed | | +1 :green_heart: | javadoc | 3m 38s | | the patch passed | | +1 :green_heart: | shadedclient | 159m 24s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | asflicense | 5m 31s | | The patch does not generate ASF License warnings. | | | | 434m 15s | | | | Subsystem | Report/Notes | |----------:|:-------------| | GITHUB PR | https://github.com/apache/hadoop/pull/6826 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | MINGW64_NT-10.0-17763 42a9d20631d9 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys | | Build tool | maven | | Personality | /c/hadoop/dev-support/bin/hadoop.sh | | git revision | trunk / 5f042ded4b7bb9ce826cd9e8b65c08a16e79aea9 | | Default Java | Azul Systems, Inc.-1.8.0_332-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6826/1/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6826/1/console | | versions | git=2.45.0.windows.1 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > getMetadataInputStream should use getShareDeleteFileInputStream for windows > --------------------------------------------------------------------------- > > Key: HDFS-17526 > URL: https://issues.apache.org/jira/browse/HDFS-17526 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 3.3.4 > Reporter: Danny Becker > Priority: Major > Labels: pull-request-available > > In HDFS-10636, the getDataInputStream method uses the > getShareDeleteFileInputStream for windows, but the getMetaDataInputStream > does not use this. The following error can happen when a DataNode is trying > to update the genstamp on a block in Windows. > DataNode Logs: > {{Caused by: java.io.IOException: Failed to rename > G:\data\hdfs\data\current\BP-1\current\finalized\subdir5\subdir16\blk_1_1.meta > to > G:\data\hdfs\data\current\BP-1\current\finalized\subdir5\subdir16\blk_1_2.meta > due to failure in native rename. 32: The process cannot access the file > because it is being used by another process.}} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org